Conversation
ad0f955 to
2e2e9d5
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~918574e159, baseline=1.60.0-SNAPSHOT~434bc8af31
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067418
Total [baseline] (10.901 s) : 0, 10900650
Agent [candidate] (1.063 s) : 0, 1063067
Total [candidate] (10.782 s) : 0, 10782284
section appsec
Agent [baseline] (1.241 s) : 0, 1240569
Total [baseline] (11.143 s) : 0, 11143485
Agent [candidate] (1.248 s) : 0, 1247687
Total [candidate] (11.033 s) : 0, 11033442
section iast
Agent [baseline] (1.236 s) : 0, 1236366
Total [baseline] (11.198 s) : 0, 11197825
Agent [candidate] (1.232 s) : 0, 1231825
Total [candidate] (11.23 s) : 0, 11230036
section profiling
Agent [baseline] (1.2 s) : 0, 1199923
Total [baseline] (11.085 s) : 0, 11084828
Agent [candidate] (1.191 s) : 0, 1191272
Total [candidate] (10.905 s) : 0, 10905122
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~918574e159, baseline=1.60.0-SNAPSHOT~434bc8af31
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (630.034 ms) : 0, 630034
BytebuddyAgent [candidate] (628.017 ms) : 0, 628017
AgentMeter [baseline] (29.027 ms) : 0, 29027
AgentMeter [candidate] (28.906 ms) : 0, 28906
GlobalTracer [baseline] (258.097 ms) : 0, 258097
GlobalTracer [candidate] (257.256 ms) : 0, 257256
AppSec [baseline] (32.947 ms) : 0, 32947
AppSec [candidate] (32.726 ms) : 0, 32726
Debugger [baseline] (62.249 ms) : 0, 62249
Debugger [candidate] (62.466 ms) : 0, 62466
Remote Config [baseline] (647.374 µs) : 0, 647
Remote Config [candidate] (635.212 µs) : 0, 635
Telemetry [baseline] (12.525 ms) : 0, 12525
Telemetry [candidate] (12.148 ms) : 0, 12148
Flare Poller [baseline] (5.422 ms) : 0, 5422
Flare Poller [candidate] (4.443 ms) : 0, 4443
section appsec
crashtracking [baseline] (1.175 ms) : 0, 1175
crashtracking [candidate] (1.213 ms) : 0, 1213
BytebuddyAgent [baseline] (658.324 ms) : 0, 658324
BytebuddyAgent [candidate] (663.59 ms) : 0, 663590
AgentMeter [baseline] (11.976 ms) : 0, 11976
AgentMeter [candidate] (12.058 ms) : 0, 12058
GlobalTracer [baseline] (258.416 ms) : 0, 258416
GlobalTracer [candidate] (259.809 ms) : 0, 259809
AppSec [baseline] (168.56 ms) : 0, 168560
AppSec [candidate] (168.388 ms) : 0, 168388
Debugger [baseline] (67.469 ms) : 0, 67469
Debugger [candidate] (67.414 ms) : 0, 67414
Remote Config [baseline] (655.14 µs) : 0, 655
Remote Config [candidate] (642.274 µs) : 0, 642
Telemetry [baseline] (9.611 ms) : 0, 9611
Telemetry [candidate] (9.828 ms) : 0, 9828
Flare Poller [baseline] (3.741 ms) : 0, 3741
Flare Poller [candidate] (3.747 ms) : 0, 3747
IAST [baseline] (25.259 ms) : 0, 25259
IAST [candidate] (25.544 ms) : 0, 25544
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (798.424 ms) : 0, 798424
BytebuddyAgent [candidate] (795.427 ms) : 0, 795427
AgentMeter [baseline] (11.359 ms) : 0, 11359
AgentMeter [candidate] (11.265 ms) : 0, 11265
GlobalTracer [baseline] (249.438 ms) : 0, 249438
GlobalTracer [candidate] (248.452 ms) : 0, 248452
AppSec [baseline] (34.022 ms) : 0, 34022
AppSec [candidate] (34.724 ms) : 0, 34724
Debugger [baseline] (66.739 ms) : 0, 66739
Debugger [candidate] (65.714 ms) : 0, 65714
Remote Config [baseline] (546.393 µs) : 0, 546
Remote Config [candidate] (542.297 µs) : 0, 542
Telemetry [baseline] (8.623 ms) : 0, 8623
Telemetry [candidate] (8.715 ms) : 0, 8715
Flare Poller [baseline] (3.556 ms) : 0, 3556
Flare Poller [candidate] (3.526 ms) : 0, 3526
IAST [baseline] (27.124 ms) : 0, 27124
IAST [candidate] (26.969 ms) : 0, 26969
section profiling
ProfilingAgent [baseline] (100.046 ms) : 0, 100046
ProfilingAgent [candidate] (99.342 ms) : 0, 99342
crashtracking [baseline] (1.233 ms) : 0, 1233
crashtracking [candidate] (1.226 ms) : 0, 1226
BytebuddyAgent [baseline] (687.479 ms) : 0, 687479
BytebuddyAgent [candidate] (682.481 ms) : 0, 682481
AgentMeter [baseline] (8.688 ms) : 0, 8688
AgentMeter [candidate] (8.656 ms) : 0, 8656
GlobalTracer [baseline] (217.499 ms) : 0, 217499
GlobalTracer [candidate] (216.208 ms) : 0, 216208
AppSec [baseline] (32.941 ms) : 0, 32941
AppSec [candidate] (32.568 ms) : 0, 32568
Debugger [baseline] (68.094 ms) : 0, 68094
Debugger [candidate] (67.582 ms) : 0, 67582
Remote Config [baseline] (645.889 µs) : 0, 646
Remote Config [candidate] (623.471 µs) : 0, 623
Telemetry [baseline] (9.073 ms) : 0, 9073
Telemetry [candidate] (8.965 ms) : 0, 8965
Flare Poller [baseline] (3.834 ms) : 0, 3834
Flare Poller [candidate] (3.788 ms) : 0, 3788
Profiling [baseline] (100.624 ms) : 0, 100624
Profiling [candidate] (99.925 ms) : 0, 99925
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~918574e159, baseline=1.60.0-SNAPSHOT~434bc8af31
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062743
Total [baseline] (8.761 s) : 0, 8760583
Agent [candidate] (1.072 s) : 0, 1071769
Total [candidate] (8.769 s) : 0, 8768804
section iast
Agent [baseline] (1.232 s) : 0, 1232166
Total [baseline] (9.337 s) : 0, 9337407
Agent [candidate] (1.24 s) : 0, 1240155
Total [candidate] (9.337 s) : 0, 9337124
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~918574e159, baseline=1.60.0-SNAPSHOT~434bc8af31
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (628.261 ms) : 0, 628261
BytebuddyAgent [candidate] (633.156 ms) : 0, 633156
AgentMeter [baseline] (28.895 ms) : 0, 28895
AgentMeter [candidate] (29.291 ms) : 0, 29291
GlobalTracer [baseline] (257.317 ms) : 0, 257317
GlobalTracer [candidate] (259.192 ms) : 0, 259192
AppSec [baseline] (32.581 ms) : 0, 32581
AppSec [candidate] (33.074 ms) : 0, 33074
Debugger [baseline] (61.847 ms) : 0, 61847
Debugger [candidate] (62.372 ms) : 0, 62372
Remote Config [baseline] (619.525 µs) : 0, 620
Remote Config [candidate] (635.501 µs) : 0, 636
Telemetry [baseline] (10.682 ms) : 0, 10682
Telemetry [candidate] (12.904 ms) : 0, 12904
Flare Poller [baseline] (6.16 ms) : 0, 6160
Flare Poller [candidate] (4.532 ms) : 0, 4532
section iast
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (796.665 ms) : 0, 796665
BytebuddyAgent [candidate] (803.759 ms) : 0, 803759
AgentMeter [baseline] (11.26 ms) : 0, 11260
AgentMeter [candidate] (11.603 ms) : 0, 11603
GlobalTracer [baseline] (248.153 ms) : 0, 248153
GlobalTracer [candidate] (249.023 ms) : 0, 249023
IAST [baseline] (27.17 ms) : 0, 27170
IAST [candidate] (26.861 ms) : 0, 26861
AppSec [baseline] (34.865 ms) : 0, 34865
AppSec [candidate] (34.002 ms) : 0, 34002
Debugger [baseline] (64.815 ms) : 0, 64815
Debugger [candidate] (65.66 ms) : 0, 65660
Remote Config [baseline] (543.675 µs) : 0, 544
Remote Config [candidate] (529.421 µs) : 0, 529
Telemetry [baseline] (8.669 ms) : 0, 8669
Telemetry [candidate] (8.592 ms) : 0, 8592
Flare Poller [baseline] (3.46 ms) : 0, 3460
Flare Poller [candidate] (3.511 ms) : 0, 3511
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~918574e159, baseline=1.60.0-SNAPSHOT~434bc8af31
dateFormat X
axisFormat %s
section baseline
no_agent (1.178 ms) : 1166, 1189
. : milestone, 1178,
iast (3.189 ms) : 3143, 3235
. : milestone, 3189,
iast_FULL (5.889 ms) : 5830, 5949
. : milestone, 5889,
iast_GLOBAL (3.582 ms) : 3517, 3647
. : milestone, 3582,
profiling (2.201 ms) : 2179, 2222
. : milestone, 2201,
tracing (1.8 ms) : 1785, 1815
. : milestone, 1800,
section candidate
no_agent (1.188 ms) : 1177, 1199
. : milestone, 1188,
iast (3.121 ms) : 3078, 3164
. : milestone, 3121,
iast_FULL (6.011 ms) : 5949, 6073
. : milestone, 6011,
iast_GLOBAL (3.385 ms) : 3337, 3433
. : milestone, 3385,
profiling (2.035 ms) : 2018, 2053
. : milestone, 2035,
tracing (1.77 ms) : 1755, 1785
. : milestone, 1770,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~918574e159, baseline=1.60.0-SNAPSHOT~434bc8af31
dateFormat X
axisFormat %s
section baseline
no_agent (18.033 ms) : 17851, 18216
. : milestone, 18033,
appsec (18.602 ms) : 18411, 18793
. : milestone, 18602,
code_origins (17.585 ms) : 17412, 17759
. : milestone, 17585,
iast (17.632 ms) : 17459, 17804
. : milestone, 17632,
profiling (19.745 ms) : 19549, 19942
. : milestone, 19745,
tracing (17.701 ms) : 17526, 17875
. : milestone, 17701,
section candidate
no_agent (17.799 ms) : 17619, 17978
. : milestone, 17799,
appsec (18.372 ms) : 18187, 18558
. : milestone, 18372,
code_origins (17.577 ms) : 17403, 17750
. : milestone, 17577,
iast (17.419 ms) : 17245, 17593
. : milestone, 17419,
profiling (19.345 ms) : 19153, 19536
. : milestone, 19345,
tracing (17.479 ms) : 17307, 17651
. : milestone, 17479,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~918574e159, baseline=1.60.0-SNAPSHOT~434bc8af31
dateFormat X
axisFormat %s
section baseline
no_agent (14.936 s) : 14936000, 14936000
. : milestone, 14936000,
appsec (14.839 s) : 14839000, 14839000
. : milestone, 14839000,
iast (17.982 s) : 17982000, 17982000
. : milestone, 17982000,
iast_GLOBAL (17.813 s) : 17813000, 17813000
. : milestone, 17813000,
profiling (14.648 s) : 14648000, 14648000
. : milestone, 14648000,
tracing (14.767 s) : 14767000, 14767000
. : milestone, 14767000,
section candidate
no_agent (15.378 s) : 15378000, 15378000
. : milestone, 15378000,
appsec (14.756 s) : 14756000, 14756000
. : milestone, 14756000,
iast (18.184 s) : 18184000, 18184000
. : milestone, 18184000,
iast_GLOBAL (17.632 s) : 17632000, 17632000
. : milestone, 17632000,
profiling (15.038 s) : 15038000, 15038000
. : milestone, 15038000,
tracing (14.79 s) : 14790000, 14790000
. : milestone, 14790000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~918574e159, baseline=1.60.0-SNAPSHOT~434bc8af31
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (3.708 ms) : 3492, 3924
. : milestone, 3708,
iast (2.249 ms) : 2181, 2318
. : milestone, 2249,
iast_GLOBAL (2.29 ms) : 2221, 2359
. : milestone, 2290,
profiling (2.07 ms) : 2016, 2124
. : milestone, 2070,
tracing (2.061 ms) : 2008, 2115
. : milestone, 2061,
section candidate
no_agent (1.467 ms) : 1456, 1478
. : milestone, 1467,
appsec (3.745 ms) : 3524, 3966
. : milestone, 3745,
iast (2.249 ms) : 2181, 2318
. : milestone, 2249,
iast_GLOBAL (2.279 ms) : 2210, 2347
. : milestone, 2279,
profiling (2.067 ms) : 2013, 2122
. : milestone, 2067,
tracing (2.044 ms) : 1991, 2097
. : milestone, 2044,
|
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
LGTM, left minor comment and one question.
| java-version: | | ||
| 8 | ||
| 11 | ||
| 17 | ||
| 21 |
There was a problem hiding this comment.
Just curious why we may need more than one java for Gradle lockfiles update?
There was a problem hiding this comment.
I wonder what happens for some modules need specific Java version?
It might not be needed for dependency resolution. I will give it another try as not specifying such JDK versions we decrease the maintenance burden.
There was a problem hiding this comment.
Yep, we can try to use 21? It should support all previous versions I hope...
There was a problem hiding this comment.
Yes, it seems to be running but I can properly test with the current master failure.
I refactor the workflow to use a one-pass upgrade. It should be faster too.
There was a problem hiding this comment.
It seems to be failing with Xerces parsing error.... No sure if it's related to some dependencies or the setup.
https://github.com/DataDog/dd-trace-java/actions/runs/21703975990/job/62590444230#step:6:584
There was a problem hiding this comment.
I can confirm it was the issue.
@bric3 Do you know why we still need the following setup:
JAVA_HOME=$JAVA_HOME_8_X64 \
JAVA_8_HOME=$JAVA_HOME_8_X64 \
JAVA_11_HOME=$JAVA_HOME_11_X64 \
JAVA_17_HOME=$JAVA_HOME_17_X64 \
JAVA_21_HOME=$JAVA_HOME_21_X64 \
JAVA_25_HOME=$JAVA_HOME_25_X64 \and why the usual Java setup is not enough?
- uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5.2.0
with:
distribution: 'temurin'
java-version: '21'
cache: 'gradle'a57442f to
3a0623d
Compare
| # - uses: DataDog/dd-octo-sts-action@acaa02eee7e3bb0839e4272dacb37b8f3b58ba80 # v1.0.3 | ||
| # id: octo-sts | ||
| # with: | ||
| # scope: DataDog/dd-trace-java | ||
| # policy: self.update-gradle-dependencies.create-pr |
There was a problem hiding this comment.
I assume this will be uncommented before merging? Otherwise looks good!
There was a problem hiding this comment.
Yes, it's containing few changes (like the additionnal trigger) to test it on my branch.
I just pushed it late as I were waiting for master to build again.
3a0623d to
957d0cc
Compare
2bdb4d4 to
9619d29
Compare
e729237 to
2856c76
Compare
2856c76 to
918574e
Compare
What Does This Do
This PR splits the Gradle lock update into two PRs:
Additionally, it improves the JDK setup, gradle cache and generated PR description.
Motivation
The current workflow updates all 516 lock files in a single PR, which creates large PRs that are difficult to review and mixes unrelated dependency changes (core vs instrumentation). Splitting into two jobs creates smaller, focused PRs (77 files for core, 439 files for instrumentation) and allows independent review and merge of each category.
Additional Notes
I tested the Java setup and the build works fine. But the PR creation requires to be run from
masterto get the proper token.Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]